[SOLR-8946] bin/post script stdin detection is faulty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 5.5.2, 5.6, 6.0.1, 6.1
• Component/s: SimplePostTool

Environment

Ubuntu

• Assignee: David Smiley
• Reporter: David Smiley
• Created: 05/Apr/16 17:40
• Updated: 25/Jun/16 20:33
• Resolved: 17/Jun/16 20:17

Description

Summary: I think the post bash script tries to detect stdin the wrong way.

If I run "post -h" I see some examples, to include this:

echo '{commit: {}}' | bin/post -c my_collection -type application/json -out yes -d

However if I try it, Solr returns this error: Cannot parse provided JSON: JSON Parse Error: char=<,position=0 BEFORE='<' AFTER='add/>'

I see that post is sending an <add /> in certain cases, but it's not supposed to when the mode is stdin. Looking closer, it appears to be because of this line:
if [[ -s /dev/stdin ]]; then
If I change it to this (which I figured out after googling around; I'm no bash expert!):
if [[ ! -t 0 ]]; then
Apparently '0' represents stdin. It works for me. thelabdude might you take a look? I'd be happy to add a formal patch & commit for this trivial change but it really needs other eyes.