Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8385

Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 6.0
    • 6.3, 7.0
    • SolrJ

    Description

      Currently, StreamFactory has several overloaded withFunctionName methods. One of these, takes two parameters: a String functionName, and a Class implementation type.

      This second parameter is a little too generic, because it's really only ever valid for a small, small subset of classes (i.e. Class<? extends Expressible ). Narrowing the type of this parameter is a small step towards preventing accidental misconfiguration of a StreamFactory.

      Attachments

        1. SOLR-8385.patch
          12 kB
          Kevin Risden
        2. SOLR-8385.patch
          4 kB
          Jason Gerlowski

        Issue Links

          Activity

            People

              krisden Kevin Risden
              gerlowskija Jason Gerlowski
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: