[SOLR-7843] Importing Delta create a memory leak

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.2.1
• Fix Version/s: 5.4, 6.0
• Component/s: contrib - DataImportHandler
• Labels: memory-leak
• Assignee: Shalin Shekhar Mangar
• Reporter: Pablo Lozano
• Created: 28/Jul/15 16:52
• Updated: 09/May/16 18:45
• Resolved: 22/Oct/15 19:17

Description

The org.apache.solr.handler.dataimport.SolrWriter is not correctly cleaning itself after finishing importing Deltas as the "Set<Object> deltaKeys" is not being cleaned after the process has finished.

When using a custom importer or DataSource for my case I need to add additional parameters to the delta keys.

When the data import finishes the DeltaKeys is not set back to null and the DataImporter, DocBuilder and the SolrWriter are mantained as live objects because there are being referenced by the "infoRegistry" of the SolrCore which seems to be used for Jmx information.

It appears that starting a second delta import did not freed the memory which may cause on the long run an OutOfMemory, I have not checked if starting a full import would break the references and free the memory.

An easy fix is possible which would be to add to the SolrWriter "deltaKeys = null;" on the close method.
Or nullify the writer on DocBuilder after being used on the method execute();