Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7007

DistributedUpdateProcessor logs replay status as int instead of boolean

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 4.10.3
    • 5.4, 6.0
    • replication (java)

    Description

      When logging the following line:

      DistributedUpdateProcessor.java
              log.info("Ignoring commit while not ACTIVE - state: " + ulog.getState() + " replay:" + (cmd.getFlags() & UpdateCommand.REPLAY));

      We display the value of the replay flag as an int instead of a boolean. This can erroneously lead operators to believe that it is a counter instead of a flag when all they see is the log.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cpoerschke Christine Poerschke
            mdrob Mike Drob
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment