Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6729

createNodeSet.shuffle=(true|false) support for /admin/collections?action=CREATE

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • None
    • None

    Description

      The 'Replica placement strategy for solrcloud' SOLR-6220 ticket will allow more sophisticated replica placement logic but in the meantime this simple change here would allow more predictable locating of replicas via the ordering of the createNodeSet list provided.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            Github user cpoerschke closed the pull request at:

            https://github.com/apache/lucene-solr/pull/103

            githubbot ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/103
            anshum Anshum Gupta added a comment -

            Bulk close after 5.0 release.

            anshum Anshum Gupta added a comment - Bulk close after 5.0 release.
            markrmiller@gmail.com Mark Miller added a comment -

            Thanks guys!

            markrmiller@gmail.com Mark Miller added a comment - Thanks guys!

            Commit 1647656 from markrmiller@gmail.com in branch 'dev/branches/branch_5x'
            [ https://svn.apache.org/r1647656 ]

            SOLR-6729: createNodeSet.shuffle=(true|false) support for /admin/collections?action=CREATE.

            jira-bot ASF subversion and git services added a comment - Commit 1647656 from markrmiller@gmail.com in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1647656 ] SOLR-6729 : createNodeSet.shuffle=(true|false) support for /admin/collections?action=CREATE.

            Commit 1647654 from markrmiller@gmail.com in branch 'dev/trunk'
            [ https://svn.apache.org/r1647654 ]

            SOLR-6729: createNodeSet.shuffle=(true|false) support for /admin/collections?action=CREATE.

            jira-bot ASF subversion and git services added a comment - Commit 1647654 from markrmiller@gmail.com in branch 'dev/trunk' [ https://svn.apache.org/r1647654 ] SOLR-6729 : createNodeSet.shuffle=(true|false) support for /admin/collections?action=CREATE.

            Updated https://github.com/apache/lucene-solr/pull/103 content:

            • createNodeSet.shuffle support scope reduced to collection CREATE only
            • OverseerCollectionProcessorTest logic added to check that unshuffled node sets result in expected layout
            • OverseerCollectionProcessorTest change also includes sometimes-random-sorting of the createNodeSet list (irrespective of createNodeSet.shuffle parameter use)
            cpoerschke Christine Poerschke added a comment - Updated https://github.com/apache/lucene-solr/pull/103 content: createNodeSet.shuffle support scope reduced to collection CREATE only OverseerCollectionProcessorTest logic added to check that unshuffled node sets result in expected layout OverseerCollectionProcessorTest change also includes sometimes-random-sorting of the createNodeSet list (irrespective of createNodeSet.shuffle parameter use)

            I added some preliminary testing (randomly turn on/off shuffling) so that we verify it still ends up creating replicas as usual, Christine/Mark: feel free to improve on it. It's a bit harder to actually verify if no shuffling was done, I will give it a shot once I get get a moment to get my head around the verifySubmitCaptures code there..

            andyetitmoves Ramkumar Aiyengar added a comment - I added some preliminary testing (randomly turn on/off shuffling) so that we verify it still ends up creating replicas as usual, Christine/Mark: feel free to improve on it. It's a bit harder to actually verify if no shuffling was done, I will give it a shot once I get get a moment to get my head around the verifySubmitCaptures code there..
            markrmiller@gmail.com Mark Miller added a comment -

            Looks good. We should probably add a simple test though.

            markrmiller@gmail.com Mark Miller added a comment - Looks good. We should probably add a simple test though.
            githubbot ASF GitHub Bot added a comment -

            GitHub user cpoerschke opened a pull request:

            https://github.com/apache/lucene-solr/pull/103

            createNodeSet.shuffle=(true|false) support, createNodeSet for ADDREPLICA

            https://issues.apache.org/jira/i#browse/SOLR-6729

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/bloomberg/lucene-solr trunk-createNodeSet-shuffle

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/lucene-solr/pull/103.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #103


            commit a2b29a72f9bcf2fa1012cd300f206789dacd0dcd
            Author: Christine Poerschke <cpoerschke@bloomberg.net>
            Date: 2014-10-13T16:33:46Z

            solr: add createNodeSet.shuffle=(true|false) support, add createNodeSet support for ADDREPLICA


            githubbot ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/103 createNodeSet.shuffle=(true|false) support, createNodeSet for ADDREPLICA https://issues.apache.org/jira/i#browse/SOLR-6729 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-createNodeSet-shuffle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit a2b29a72f9bcf2fa1012cd300f206789dacd0dcd Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-10-13T16:33:46Z solr: add createNodeSet.shuffle=(true|false) support, add createNodeSet support for ADDREPLICA

            People

              markrmiller@gmail.com Mark Miller
              cpoerschke Christine Poerschke
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: