[SOLR-6279] cores?action=UNLOAD can unregister unclosed core

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.5, 6.0
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 25/Jul/14 11:39
• Updated: 09/May/16 18:56
• Resolved: 15/Jan/16 11:22

Description

baseline:

  /somewhere/instanceA/collection1_shard1/core.properties
  /somewhere/instanceA/collection1_shard1/data
  /somewhere/instanceA/collection1_shard2/core.properties
  /somewhere/instanceA/collection1_shard2/data

  /somewhere/instanceB

actions:

  curl "http://host:port/solr/admin/cores?action=UNLOAD&core=collection1_shard2"

  # since UNLOAD completed we should now be free to move the unloaded core's files as we wish

  mv /somewhere/instanceA/collection1_shard2 /somewhere/instanceB/collection1_shard2

expected result:

  /somewhere/instanceA/collection1_shard1/core.properties
  /somewhere/instanceA/collection1_shard1/data

  # collection1_shard2 files have been fully relocated

  /somewhere/instanceB/collection1_shard2/core.properties.unloaded
  /somewhere/instanceB/collection1_shard2/data

actual result:

  /somewhere/instanceA/collection1_shard1/core.properties
  /somewhere/instanceA/collection1_shard1/data
  /somewhere/instanceA/collection1_shard2/data

  # collection1_shard2 files have not been fully relocated and/or some files were left behind in instanceA because the UNLOAD action had returned prior to the core being closed

  /somewhere/instanceB/collection1_shard2/core.properties.unloaded
  /somewhere/instanceB/collection1_shard2/data

proposed fix: Changing CoreContainer.unload to wait for core to close before unregistering it from ZK. Adding testMidUseUnload method to TestLazyCores.