Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5895

JavaBinLoader hides IOExceptions

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.7.1, 6.0
    • None
    • None

    Description

      An IOException raised during analysis is swallowed by JavabinLoader, so the underlying cause is not visible in the logs, or to the client. Proposed fix is to change

      throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "ERROR adding document " + document);
      

      to

      throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "ERROR adding document " + document, e);
      

      on line 99 in JavaBinLoader.java

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shalin Shalin Shekhar Mangar
            sokolov Michael Sokolov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment