[SOLR-4920] DIH JdbcDataSource exception handling

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3, 6.0
• Fix Version/s: 4.4
• Component/s: contrib - DataImportHandler
• Assignee: Shalin Shekhar Mangar
• Reporter: Chris Eldredge
• Created: 12/Jun/13 20:03
• Updated: 09/May/16 18:58
• Resolved: 13/Jun/13 07:15

Description

JdbcDataSource will incorrectly suppress exceptions when retrieving a connection from a JNDI context and fall back to trying to use DriverManager to obtain a connection. This makes it impossible to troubleshoot misconfigured JNDI DataSource.

Additionally, when a SQLException is thrown while initializing a connection, such as in setAutoCommit(), the connection will not be closed. This can cause a resource leak.

A patch will be attached with unit tests that addresses both issues.