[SOLR-4682] CoreAdminRequest.mergeIndexes can not merge mutilple cores.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2
• Fix Version/s: 4.3, 6.0
• Component/s: clients - java
• Labels: patch

Environment

java version "1.6.0_20"

• Assignee: Shalin Shekhar Mangar Assign to me
• Reporter: Jason.D.Cao
• Created: 06/Apr/13 05:12
• Updated: 09/May/16 18:46
• Resolved: 06/Apr/13 06:01

Description

The mergeIndexes method in CoreAdminRequest class accepts an array of srcCores, but it only merge the last core of array into targetCore. Related code as follows,

CoreAdminRequest.java

if (srcCores != null) {
	for (String srcCore : srcCores) {
		params.set(CoreAdminParams.SRC_CORE, srcCore);
	}
}

The for-each loop above overrides the SRC_CORE value in params and only the last one reserved when loop ends.
We should remove the for-each loop and set SRC_CORE value with an array of srcCores.
The code above is in CoreAdminRequest class line 330