Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4210

Requests to a Collection that does not exist on the receiving node should be proxied to a suitable node.

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0-BETA, 4.0
    • 4.2, 6.0
    • SolrCloud
    • None

    Description

      It only check the local collection or core when searching, doesn't look on other nodes. e.g. a cluster have 4 nodes. 1th 2th 3th contribute to "collection1". 2th 3th 4th contribute to "collection2". now send query to 4th to searching "collection1" will failed.
      It is an imperfect feature for searching. it is a TODO part in SolrDispatchFilter-line 220.

      Attachments

        1. SOLR-4210.patch
          2 kB
          Yonik Seeley
        2. SOLR-4210.patch
          10 kB
          Mark Miller
        3. SOLR-4210.patch
          9 kB
          Mark Miller
        4. SOLR-4210.patch
          4 kB
          Po Rui

        Issue Links

          Activity

            markrmiller@gmail.com Mark Miller added a comment -

            Thanks Po! Never saw this issue - I was just about to tackle this myself. I'll add some testing to your patch.

            markrmiller@gmail.com Mark Miller added a comment - Thanks Po! Never saw this issue - I was just about to tackle this myself. I'll add some testing to your patch.
            markrmiller@gmail.com Mark Miller added a comment -

            Along with tests, I think we want to update this to work with binary (javabin, etc) as well as other urls beyond the 'select' handler.

            markrmiller@gmail.com Mark Miller added a comment - Along with tests, I think we want to update this to work with binary (javabin, etc) as well as other urls beyond the 'select' handler.
            markrmiller@gmail.com Mark Miller added a comment -

            Here is a first pass at something more generic - it attempts to forward for all appropriate requests. Also has a simple test.

            markrmiller@gmail.com Mark Miller added a comment - Here is a first pass at something more generic - it attempts to forward for all appropriate requests. Also has a simple test.
            markrmiller@gmail.com Mark Miller added a comment -

            New patch: tightened up, more testing.

            markrmiller@gmail.com Mark Miller added a comment - New patch: tightened up, more testing.
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1450015

            SOLR-4210: Requests to a Collection that does not exist on the receiving node should be proxied to a suitable node.

            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1450015 SOLR-4210 : Requests to a Collection that does not exist on the receiving node should be proxied to a suitable node.
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1450016

            SOLR-4210: Requests to a Collection that does not exist on the receiving node should be proxied to a suitable node.

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1450016 SOLR-4210 : Requests to a Collection that does not exist on the receiving node should be proxied to a suitable node.
            markrmiller@gmail.com Mark Miller added a comment -

            Thanks Po!

            markrmiller@gmail.com Mark Miller added a comment - Thanks Po!
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1450043

            SOLR-4210: clean up error case

            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1450043 SOLR-4210 : clean up error case
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1450045

            SOLR-4210: clean up error case

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1450045 SOLR-4210 : clean up error case
            yseeley@gmail.com Yonik Seeley added a comment -

            Here's a patch to copy from the streams a block at a time rather than a byte at a time.
            I also commented questioning the closing of the servlet streams.

            I didn't commit since I'm not sure if this has tests yet...

            yseeley@gmail.com Yonik Seeley added a comment - Here's a patch to copy from the streams a block at a time rather than a byte at a time. I also commented questioning the closing of the servlet streams. I didn't commit since I'm not sure if this has tests yet...
            markrmiller@gmail.com Mark Miller added a comment -

            There is a basic test at BasicDistributedZk2Test#testNodeWithoutCollectionForwarding

            markrmiller@gmail.com Mark Miller added a comment - There is a basic test at BasicDistributedZk2Test#testNodeWithoutCollectionForwarding
            markrmiller@gmail.com Mark Miller added a comment -

            I also commented questioning the closing of the servlet streams.

            Yeah, I don't know for sure - I didn't originally, then saw some code that did, so I just followed suit.

            Didn't seem to hurt either way.

            markrmiller@gmail.com Mark Miller added a comment - I also commented questioning the closing of the servlet streams. Yeah, I don't know for sure - I didn't originally, then saw some code that did, so I just followed suit. Didn't seem to hurt either way.
            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1451987 SOLR-4210 : Fix it
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1451989

            SOLR-4210: Fix it

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1451989 SOLR-4210 : Fix it
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1452069

            SOLR-4210: More efficient stream copying

            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1452069 SOLR-4210 : More efficient stream copying
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1452070

            SOLR-4210: More efficient stream copying

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1452070 SOLR-4210 : More efficient stream copying
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1452073

            SOLR-4210: Update CHANGES

            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1452073 SOLR-4210 : Update CHANGES
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1452074

            SOLR-4210: Update CHANGES

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1452074 SOLR-4210 : Update CHANGES
            sarowe Steven Rowe added a comment - Proxying GET requests fails - I'm going to fix under SOLR-4503 - see https://issues.apache.org/jira/browse/SOLR-4503?focusedCommentId=13593005&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13593005 .
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Steven Rowe
            http://svn.apache.org/viewvc?view=revision&revision=1453161

            SOLR-4503: Add REST API methods to get schema information: fields, dynamicFields, fieldTypes, and copyFields. Restlet 2.1.1 is integrated and is used to service these requests.
            Also fixes bugs in dynamic copyField logic described in SOLR-3798.
            Also fixes a bug with proxied SolrCloud requests (SOLR-4210) when using the GET method.

            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1453161 SOLR-4503 : Add REST API methods to get schema information: fields, dynamicFields, fieldTypes, and copyFields. Restlet 2.1.1 is integrated and is used to service these requests. Also fixes bugs in dynamic copyField logic described in SOLR-3798 . Also fixes a bug with proxied SolrCloud requests ( SOLR-4210 ) when using the GET method.
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Steven Rowe
            http://svn.apache.org/viewvc?view=revision&revision=1453162

            SOLR-4503: Add REST API methods to get schema information: fields, dynamicFields, fieldTypes, and copyFields. Restlet 2.1.1 is integrated and is used to service these requests.
            Also fixes bugs in dynamic copyField logic described in SOLR-3798.
            Also fixes a bug with proxied SolrCloud requests (SOLR-4210) when using the GET method.
            (merged trunk r1453161)

            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1453162 SOLR-4503 : Add REST API methods to get schema information: fields, dynamicFields, fieldTypes, and copyFields. Restlet 2.1.1 is integrated and is used to service these requests. Also fixes bugs in dynamic copyField logic described in SOLR-3798 . Also fixes a bug with proxied SolrCloud requests ( SOLR-4210 ) when using the GET method. (merged trunk r1453161)
            uschindler Uwe Schindler added a comment -

            Closed after release.

            uschindler Uwe Schindler added a comment - Closed after release.

            People

              markrmiller@gmail.com Mark Miller
              brui Po Rui
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: