Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4166

LBHttpSolrServer should not ignore specified ResponseParser

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0
    • 4.1, 6.0
    • clients - java
    • None

    Description

      Even when using the constructor specifying which ResponseParser to use, LBHttpSolrServer always uses its internal BinaryResponseParser. This forces anyone who wants to use another parser to extend the LBHttpSolrServer class instead of passing it the desired parser, or even null in order to get the original stream.

      In general, it makes sense to have default values, and BinaryResponseParser is probably the best choice for LBHttpSolrServer, but ignoring the parameter is error prone for users.

      Attachments

        1. patch-4166.txt
          4 kB
          Steve Molloy

        Issue Links

          Activity

            People

              markrmiller@gmail.com Mark Miller
              smolloy Steve Molloy
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: