[SOLR-17567] Improve Stream CLI implementation

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: cli
• Security Level: Public (Default Security Level. Issues are Public)
• Labels: cli pull-request-available streams
• Assignee: Unassigned
• Reporter: Christos Malliaridis
• Created: 3 days ago 15:20
• Updated: Yesterday 13:08

Description

The current implemention for the CLI's Streams command that was introduced in SOLR-14673 has multiple issues that should be addressed, including but not limited to:

• Use of raw strings in Option#getOptionValue()
• Overlapping options (-f and -e)
• Multiple type suppressions that can be avoided
• A bug that causes specific bats tests to fail
• StreamTool.LocalCatStream overrides CatStream btu does not properly set commaDelimitedFilepaths (this may be a bug)
• Obsolete LetStream#getLetParams() was introduced
• Function StreamTool.constructStream seems obsolete and occurrences can be replaced with implementation
• Implementation of StreamTool.readExpression does not take leading spaces infront of comment lines into account
• Implementation of StreamTool.readExpression does not support */ at the end of line

Issue Links

• is part of: SOLR-14673 Add CLI for Streaming Expressions
• links to: GitHub Pull Request #2872
• links to: GitHub Pull Request #2877
• links to: GitHub Pull Request #2878