[SOLR-17330] Default value for 'loadOnStartup' is fuzzy

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 9.6
• Fix Version/s: 9.7
• Labels: pull-request-available
• Assignee: Eric Pugh
• Reporter: Pierre Salagnac
• Created: 12/Jun/24 12:29
• Updated: 25/Oct/24 17:18
• Resolved: 22/Jun/24 15:15

Description

Each core has property loadOnStartup to decide if the core is opened at start-up or delayed until first access.

When creating a new core and not specifying the property in the request, we take the default value from CoreDescriptor.defaultProperties which is true.

defaultProperties

  private static final Map<String, String> defaultProperties = Map.of(...., CORE_LOADONSTARTUP, "true");

Then, when we retrieve the value of the property in CoreDescriptor.isLoadOnStartup(), if the property is not the core stored properties, default value is false.

isLoadOnStartup()

    String tmp = coreProperties.getProperty(CORE_LOADONSTARTUP, "false");

Impact is low since all cores are created with value "true" when not explicitly created, using value from the default properties. This just makes the code confusing to read.

Issue Links

• links to: GitHub Pull Request #2513