[SOLR-16962] updateLog tlog dir location config is silently ignored

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: main (10.0), 9.2.1
• Fix Version/s: 9.7
• Assignee: Michael Gibney
• Reporter: Michael Gibney
• Created: 06/Sep/23 19:09
• Updated: 02/Jul/24 16:59
• Resolved: 13/Jun/24 16:53

Description

If you follow the instructions on configuring a non-default tlog location, solr currently silently ignores explicit configuration and uses the default location [instanceDir]/data/tlog/.

Afaict this has been the case for some time, with several layers of faithful refactorings now somewhat obscuring the initial intent.

This issue proposes to restore the initial intent, and also shore up some of the nuances of handling this (now that the config actually has an effect):

1. resolve relative "dir" spec relative to core instanceDir
2. disallow relative "dir" spec that escapes core instanceDir (e.g., dir=../../some_path)
3. for absolute "dir" spec outside of the core instanceDir, scope the tlog dir by core name

Issue Links

• links to: GitHub Pull Request #1895
• links to: GitHub Pull Request #1895
• links to: GitHub Pull Request #2525
• links to: GitHub Pull Request #2537