Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16950

SimpleTracer propagation for manual transaction ids

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 9.4
    • tracing
    • None

    Description

      This only applies to the always-on simple tracer. Being able to pass in a custom trace header and have it correctly propagated across the cluster in all types of requests is a big feature of this component.

      I noticed that there are UpdateRequests that will not correctly propagate a manual trace headers, due to the fact that the Solr client can recreate the UpdateRequest without copying the headers over top the new request.
      There is a failing test I commented out to showcase the issue https://github.com/apache/solr/blob/ce6c13e41806233daaf25f1a7545c7aad34c169d/solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java#L75

      Attachments

        Issue Links

          Activity

            People

              stillalex Alex Deparvu
              stillalex Alex Deparvu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m