[SOLR-16924] Restore: Have RESTORECORE set the UpdateLog state

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.5
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 10/Aug/23 14:19
• Updated: 09/May/24 21:21
• Resolved: 10/Oct/23 02:47

Description

This is a refactoring improvement designed to simplify & clarify a step in collection restores. One of the final phases of RestoreCmd (collection restore) is to call REQUESTAPPLYUPDATES on each newly restored replica in order to transition the state of the UpdateLog to ACTIVE (not actually to apply updates). The underlying call on the UpdateLog could instead be done inside RESTORECORE at the end with explanatory comments as to the intent. I think this makes more sense that RESTORECORE finish with its UpdateLog ready. And it's strange/curious to see requests in the cluster to apply updates from an updateLog when there is none to do! Adding clarifying comments is important.

See my comment: https://issues.apache.org/jira/browse/SOLR-12065?focusedCommentId=17751792&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17751792

I think there isn't any back-compat concern.

Issue Links

• links to: GitHub Pull Request #1965