[SOLR-16845] BinaryResponseWriter should not attempt cast to Utf8CharSequence

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.4
• Component/s: query
• Assignee: Houston Putman
• Reporter: Alex Deparvu
• Created: 13/Jun/23 16:17
• Updated: 15/Oct/23 19:57
• Resolved: 17/Jul/23 13:30

Description

This is a followup of various rollbacks (mainly LUCENE-8805 but also SOLR-14013) in the use of Utf8CharSequence. basically this change https://github.com/apache/solr/commit/5a694ea26ff862ecc874ca798135073d300c2234#diff-95210db504bf3cbe4635d3d09e5e90f990d684dcd324f683e93cb498d171f63dL309 removed the creation of StoredFields based on Utf8CharSequence values, making this BinaryResponseWriter instanceof check useless (https://github.com/apache/solr/blob/66d6a55895fa51074e325d260bbdc14f8beb560a/solr/core/src/java/org/apache/solr/response/BinaryResponseWriter.java#L100).
What I see here is an unneeded call to StoredField#getCharSequenceValue for every stored field in the query response, so I am proposing to remove it.

Issue Links

• links to: GitHub Pull Request #1728