[SOLR-16715] Replace new HashMap(int) and new HashSet(int) with CollectionUtil.newHashMap / CollectionUtil.newHashSet

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.3
• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 22/Mar/23 13:43
• Updated: 21/Jul/23 20:40
• Resolved: 23/Mar/23 23:02

Description

While looking at replacing Guava, dsmiley proposed converting existing new HashMap(int) and new HashSet(int) to avoid the trap of them not actually being that size.

https://github.com/apache/solr/pull/1466#discussion_r1144811614

We should be able to enforce this with ForbiddenAPIs and https://github.com/apache/solr/pull/1466 adds CollectionUtil inspired by Lucene that we can use.

Issue Links

• links to: GitHub Pull Request #1482