[SOLR-1670] synonymfilter/map repeat bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 1.4
• Component/s: Schema and Analysis
• Assignee: Yonik Seeley
• Reporter: Robert Muir
• Created: 18/Dec/09 05:52
• Updated: 06/Oct/16 16:51
• Resolved: 06/Oct/16 16:51

Description

as part of converting tests for SOLR-1657, I ran into a problem with synonymfilter

the test for 'repeats' has a flaw, it uses this assertTokEqual construct which does not really validate that two lists of token are equal, it just stops at the shorted one.

    // repeats
    map.add(strings("a b"), tokens("ab"), orig, merge);
    map.add(strings("a b"), tokens("ab"), orig, merge);
    assertTokEqual(getTokList(map,"a b",false), tokens("ab"));
    /* in reality the result from getTokList is ab ab ab!!!!! */

when converted to assertTokenStreamContents this problem surfaced. attached is an additional assertion to the existing testcase.

Issue Links

• blocks: SOLR-1657 convert the rest of solr to use the new tokenstream API