[SOLR-16669] Http2SolrClient defaults checkPeerName incorrectly

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.2
• Component/s: http2, SolrJ
• Assignee: Houston Putman
• Reporter: Houston Putman
• Created: 17/Feb/23 17:41
• Updated: 27/Mar/23 18:07
• Resolved: 23/Feb/23 09:08

Description

While I was going through the HTTP2ClientCode I realized that the  {{ solr.ssl.checkPeerName }} option defaults to false if the system property is not provided. Instead we want it to default to true, which the documentation and the code both say is the functionality.

Fixing this in a minor version would be back-compat breaking, though it would be adhering to the provided documentation. So I'm not sure whether we want this in 9x or just 10.

Issue Links

• is related to: SOLR-16679 Fix solr.jetty.ssl.verifyClientHostName logging
• links to: GitHub Pull Request #1367