Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16649

Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • main (10.0), 9.1.1
    • 9.3, 9.2.1
    • clients - java
    • None

    Description

      Http2SolrClient:800 calls wantStream(...) method but passes the wrong argument to it - instead of passing the local processor arg it uses the instance field parser.

      Throughout this class there's a repeated pattern that easily leads to this confusion - in many methods a local var parser is created that overshadows the instance field, and then this local parser is passed around as argument to various operations. However, in this particular method the argument passed from the caller is named differently  (processor) and thus does not overshadow the instance field, which leads to this mistake.

      Attachments

        1. SOLR-16649.patch
          3 kB
          Andrzej Bialecki
        2. SOLR-16649-1.patch
          3 kB
          Andrzej Bialecki

        Activity

          People

            janhoy Jan Høydahl
            ab Andrzej Bialecki
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m