[SOLR-16638] Fix Http2SolrClient's exception message when serverBaseUrl is null

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.11.2
• Fix Version/s: main (10.0), 9.3
• Assignee: Kevin Risden
• Reporter: Alex Deparvu
• Created: 27/Jan/23 17:49
• Updated: 16/Nov/23 23:43
• Resolved: 15/Mar/23 13:12

Description

Http2SolrClient can throw a number of RemoteSolrException using the serverBaseUrl variable in the message. trouble is, this can be null, and is null for the inter node requests).

One example I recently saw had `Error from server at null` [0]

There are places in the Http2SolrClient that look at the 'solrRequest.getBasePath()' and use that instead of the serverBaseUrl, I think we could do the same for the exception message.

[0]

.... o.a.s.h.RequestHandlerBase
org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException: Error from server at null: parsing error => org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException: Error from server at null: parsing error
	at org.apache.solr.client.solrj.impl.Http2SolrClient.processErrorsAndResponse(Http2SolrClient.java:713)
org.apache.solr.client.solrj.impl.BaseHttpSolrClient$RemoteSolrException: Error from server at null: parsing error
	at org.apache.solr.client.solrj.impl.Http2SolrClient.processErrorsAndResponse(Http2SolrClient.java:713)

Issue Links

• duplicates: SOLR-15159 Missing host in error message: "Error from server at null"
• links to: GitHub Pull Request #1356