[SOLR-16631] solr.shardsWhitelist solr.allowUrls - hostnames should be treated in case insensitive way

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0, 8.11, 9.1
• Fix Version/s: main (10.0), 9.2
• Component/s: SolrCloud
• Assignee: Eric Pugh
• Reporter: Paul Blanchaert
• Created: 23/Jan/23 08:51
• Updated: 27/Mar/23 18:04
• Resolved: 06/Feb/23 15:31

Description

Given that hostnames should be case insensitive (see rfc3986;section-6.2.2.1), the check for should also consider hostnames in urls in a case insentive way.
That is not the case (not in Solr 8 and not after refactoring in Solr 9).

Most people are using always lowercases for hostnames in urls, so probably not encountered that often and there is an easy and quick fix by changing the parameter to match the actual cases used in the hostname, hence priority is "Minor". But still, it is better to comply with well-established rules.

Easy test via changing 1 char to uppercase in the hostname of the unit test AllowListUrlCheckerTest.testSingleHost().
E.g. test result:
org.apache.solr.common.SolrException: URL http://abc-1.Com:8983/solr is neither a live node of the cluster nor in the configured 'allowUrls' [abc-1.com:8983]

Note: SOLR-15340 renamed solr.shardsWhitelist to solr.allowUrls

Issue Links

• links to: GitHub Pull Request #1325