[SOLR-16507] Remove Snitch. Simplify NodeStateProvider usage.

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.3
• Labels: newdev
• Assignee: Noble Paul
• Reporter: David Smiley
• Created: 28/Oct/22 14:31
• Updated: 06/Sep/24 01:16
• Resolved: 12/Jul/23 18:05

Description

The NodeStateProvider is a relic relating to the old autoscaling framework that was removed in Solr 9.  The only remaining usage of it is for SplitShardCmd to check the disk space.  For this, it could use the metrics api. (Update: keep NodeStateProvider albeit simplify the default impl by removing Snitch stuff. Add "NodeValueFetcher").

I think we'll observe that Snitch and other classes in org.apache.solr.common.cloud.rule can be removed as well, as it's related to NodeStateProvider.

Only org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some constants in the code to be removed.  Those constants could move out, consolidated somewhere we think is appropriate.

Issue Links

• causes: SOLR-17437 Shard splits no longer check for sufficient disk space
• causes: SOLR-17099 Unsolicited snitch tag warnings from AttributeFetcherImpl
• relates to: SOLR-14656 Deprecate current autoscaling framework, remove from master
• links to: GitHub Pull Request #1485
• links to: GitHub Pull Request #1625
• links to: GitHub Pull Request #1625
• links to: GitHub Pull Request #1702
• links to: GitHub Pull Request #1775