[SOLR-16241] JettyConfig.builder(JettyConfig) misses some properties

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.1, main (10.0)
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 07/Jun/22 20:08
• Updated: 10/Jan/23 20:45
• Resolved: 27/Jun/22 22:46

Description

Since JettyConfig instances are immutable, there is a Builder pattern for them, and a static JettyConfig.builder(JettyConfig other) method to create a new Builder from an existing JettyConfig.

But this method only sets 6 of the 10 properties that available in the JettyConfig constructor (and Builder)

This can easily bite you when using any code path that depends on  JettyConfig.builder(JettyConfig other)

Notably this impacts any usage of MiniSolrCloudCluster which always calls JettyConfig.builder(JettyConfig other) when starting up jetty nodes – so 40% of the options you may try to manipulate on your JettyConfig will be completely ignored once MiniSolrCloudCluster actually starts the jetty nodes