[SOLR-16002] FilterQuery (`filter([some_query])`) can be double-cached when used in certain contexts

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: main (10.0)
• Fix Version/s: 9.1
• Assignee: Michael Gibney
• Reporter: Michael Gibney
• Created: 10/Feb/22 22:24
• Updated: 10/Jan/23 20:45
• Resolved: 29/Mar/22 18:23

Description

FilterQuery (usually invoked by the filter([inner_query]) syntax in the Standard Query Parser), can be double-cached if it's used in certain contexts. The clearest case is if you specify fq=filter(field_s:value), this will hit the filterCache twice:

1. once at the top/fq level, as a FilterQuery
2. once as the inner field_s:value query, wrapped by the FilterQuery.

This might seem like an anti-pattern, but there are cases where it's really practical to support this usage; namely, bundling main query and fqs into a single query (e.g., to use as the "foreground query" for SKG/relatedness ... but there are likely other cases). Without the ability to consult the cache for wrapped clauses, such a use case hits serious problems.

Issue Links

• links to: GitHub Pull Request #624