Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15943

Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 9.0
    • Hadoop Integration, hdfs
    • None

    Description

      LUCENE-10366 / LUCENE-10376 found that the loop unrolling isn't necessary anymore. SOLR-15405 implemented the little endian loop unrolling, but this can be simplified to avoid issues in the future.

      Example of what is needed: https://github.com/apache/lucene/pull/592 and https://github.com/apache/lucene/pull/602

        @Override
        public final int readVInt() throws IOException {
          // this can make JVM less confused (see LUCENE-10366)
          return super.readVInt();
        }
      
        @Override
        public final long readVLong() throws IOException {
          // this can make JVM less confused (see LUCENE-10366)
          return super.readVLong();
        }
      
      

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            krisden Kevin Risden
            krisden Kevin Risden
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment