[SOLR-15587] Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 8.8, 8.8.1, 8.8.2, 8.9, 8.10, 8.11, 8.10.1, 8.11.1
• Fix Version/s: 9.0, 8.11.2
• Component/s: SolrJ
• Assignee: Timothy Potter
• Reporter: Timothy Potter
• Created: 16/Aug/21 20:06
• Updated: 12/May/22 00:26
• Resolved: 08/Feb/22 00:34

Description

Assuming you have a SolrCloud cluster with TLS enabled and are instantiating a CloudSolrClient using a Solr URL vs. ZK connection string, then the changes made for SOLR-12182 in 8.8.0 have introduced a bug where the base_url for replicas in the ClusterState returned by the HttpClusterStateProvider have url scheme http instead of https when the global singleton UrlScheme.INSTANCE is not set to https. This does NOT impact ClusterState returned by the ZkClusterStateProvider because the ZkStateReader calls UrlScheme.INSTANCE.setUrlScheme("https").

The easiest work-around for now is for client applications to call:

UrlScheme.INSTANCE.setUrlScheme(UrlScheme.HTTPS);

Before creating SolrJ client objects such as CloudSolrClient.

I think the proper fix would be to call putIfAbsent in Replica ctor:

    propMap.putIfAbsent(BASE_URL_PROP, UrlScheme.INSTANCE.getBaseUrlForNodeName(this.nodeName));

but need to run all existing tests and create a new unit test for this situation.

Issue Links

• fixes: SOLR-15364 Race condition when maintaining multiple CloudSolrClients for a mix of HTTP/HTTPS clusters
• is caused by: SOLR-12182 Can not switch urlScheme in 7x if there are any cores in the cluster
• links to: GitHub Pull Request #460
• links to: GitHub Pull Request #600
• links to: GitHub Pull Request #602
• links to: GitHub Pull Request #2639