Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15209

Make the LegacyAssignStrategy the SimplePlacementFactory

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Blocker
    • Resolution: Done
    • 9.0
    • 9.0
    • None
    • None

    Description

      Currently there's a lot of code in Assign dealing with the fact that we still support the old "legacy" replica assignment as well as the new plugin-based placement strategies.

      Furthermore, the "legacy" assignment is now the default even though it's neither robust nor optimal, except in the very simple and small clusters. Also, providing another plugin-based placement as the default impl. runs into a small complication - in the absence of any plugin config the code reverts to the "legacy".

      In order to promote the adoption of the new plugin-based placements we should make the AffinityPlacementFactory the new default placement strategy, selected when the explicit configuration is missing (and then create it as a default configuration in PlacementPluginFactoryLoader).

      I propose to re-package the "legacy" strategy as a PlacementPluginFactory so that it can be configured in the same way as other placement plugins.

      Attachments

        Issue Links

          Activity

            People

              houston Houston Putman
              ab Andrzej Bialecki
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 10m
                  1h 10m