[SOLR-14961] ZkMaintenanceUtils.clean(...) doesn't delete files with same length

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0, 8.1, 8.2, 8.3, 8.4, 8.5, 8.6.3
• Fix Version/s: 8.8, 9.0
• Component/s: SolrCloud, SolrJ
• Labels: newbie
• Assignee: Mike Drob
• Reporter: def onion
• Created: 22/Oct/20 13:46
• Updated: 12/May/22 00:26
• Resolved: 02/Nov/20 23:08

Description

When trying to delete zookeeper path and all of its subnodes via ZkMaintenanceUtils.clean(SolrZkClient zkClient, String path, Predicate<String> filter) the Operation fails silently, when a ZKNode contains more than 1 file with the same file name length.

This is because of the String.length() comparator used in the Treeset for storing the paths. Paths with the same length are seen as equal and are not added to the set.

Issue Links

• links to: GitHub Pull Request #2042