[SOLR-14651] Metrics history could disable itself better

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.7
• Component/s: metrics
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 15/Jul/20 15:58
• Updated: 04/Nov/20 15:22
• Resolved: 28/Jul/20 20:50

Description

The MetricsHistoryHandler should disable itself better than it does.  It will create a SolrRrdBackendFactory (which has an ExecutorService / thread pool) when it should not when the plugin is disabled.  Furthermore, I think this should be disabled by default in tests, as it's excessive machinery that don't matter to 99.9% of tests.  This will help our tests run more efficiently.

While working on other issues, I also occasionally saw a thread leak failure with the RRD being the leaked threads.  I see that in "close", we don't wait for the executor to actually shut down but it should.

CC ab

Issue Links

• relates to: SOLR-14775 Option to disable metrics
• links to: GitHub Pull Request #1672