[SOLR-14492] many json.facet aggregations can throw ArrayIndexOutOfBoundsException when using DVHASH due to incorrect resize impl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: Facet Module
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 15/May/20 23:39
• Updated: 15/Jul/20 15:09
• Resolved: 20/May/20 22:42

Description

It appears we have quite a few SlotAcc impls that don't properly implement resize: they ask the Resizer to resize their arrays, but throw away the result. (arrays can't be resized in place, the Resizer is designed to return a new replacment map, initializing empty values and/or mapping old indicies to new indicies)

For many FacetFieldProcessors, this isn't (normally) a problem because they create their Accs using a "max upper bound" on the possible number of slots in advance – and only use resize later to "shrink" the number of slots.

But in the case of method:dvhash / FacetFieldProcessorByHashDV this processor starts out using a number of slots based on the size of the base DocSet (rounded up to the next power of 2) maxed out at 1024, and then grows the SlotAccs if it encounters more values then that.

This means that if the "base" context of the term facet is significantly smaller then the number of values in the docValues field being faceted on (ie: multiValued fields), then these problematic SlotAccs won't grow properly and you'll get ArrayIndexOutOfBoundsException