[SOLR-13835] HttpSolrCall produces incorrect extra AuditEvent on AuthorizationResponse.PROMPT

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.3
• Component/s: Authentication, Authorization
• Assignee: Jan Høydahl
• Reporter: Chris M. Hostetter
• Created: 11/Oct/19 03:08
• Updated: 21/Jan/20 16:58
• Resolved: 16/Oct/19 23:06

Description

spinning this out of SOLR-13741...

Wrt the REJECTED + UNAUTHORIZED events I see the same as you, and I believe there is a code bug, not a test bug. In HttpSolrCall#471 in the authorize() call, if authResponse == PROMPT, it will actually match both blocks and emit two audit events: https://github.com/apache/lucene-solr/blob/26ede632e6259eb9d16861a3c0f782c9c8999762/solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java#L475:L493

if (authResponse.statusCode == AuthorizationResponse.PROMPT.statusCode) {...}
if (!(authResponse.statusCode == HttpStatus.SC_ACCEPTED) && !(authResponse.statusCode == HttpStatus.SC_OK)) {...}

When code==401, it is also true that code!=200. Intuitively there should be both a sendErrora and return RETURN before line #484 in the first if block?

This causes any and all REJECTED AuditEvent messages to be accompanied by a coresponding UNAUTHORIZED AuditEvent.

It's not yet clear if, from the perspective of the external client, there are any other bugs in behavior (TBD)

Issue Links

• blocks: SOLR-13840 AuditLogger issues when logged from HttpServletRequest
• causes: SOLR-13905 Make findRequestType in AuditEvent more robust
• is duplicated by: SOLR-13840 AuditLogger issues when logged from HttpServletRequest
• relates to: SOLR-13741 AuditLoggerIntegrationTest hardening
• links to: GitHub Pull Request #946