[SOLR-13725] TermsFacetMap.setLimit() unnecessarily rejects negative parameter value

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 8.2
• Fix Version/s: 8.3
• Component/s: SolrJ
• Assignee: Munendra S N
• Reporter: Richard Walker
• Created: 29/Aug/19 00:55
• Updated: 21/Jan/20 16:56
• Resolved: 21/Sep/19 06:05

Description

SolrJ's TermsFacetMap.setLimit(int maximumBuckets) rejects a negative parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' must be non-negative".

But a negative value for the limit parameter is accepted by Solr server, and is meaningful: i.e., it means "no limit".

The setLimit() method shouldn't reject a negative parameter value.