[SOLR-13207] AIOOBE in calculateMinShouldMatch

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.4, 9.0
• Labels: diffblue newdev

Environment

Steps to reproduce

• Use a Linux machine.
• Build commit ea2c8ba of Solr as described in the section below.
• Build the films collection as described below.
• Start the server using the command ./bin/solr start -f -p 8983 -s /tmp/home
• Request the URL given in the bug description.

Compiling the server

git clone https://github.com/apache/lucene-solr
cd lucene-solr
git checkout ea2c8ba
ant compile
cd solr
ant server

Building the collection and reproducing the bug

We followed Exercise 2 from the Solr Tutorial.

mkdir -p /tmp/home
echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > /tmp/home/solr.xml

In one terminal start a Solr instance in foreground:

./bin/solr start -f -p 8983 -s /tmp/home

In another terminal, create a collection of movies, with no shards and no replication, and initialize it:

bin/solr create -c films
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' http://localhost:8983/solr/films/schema
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-copy-field" : {"source":"*","dest":"_text_"}}' http://localhost:8983/solr/films/schema
./bin/post -c films example/films/films.json
curl -v “URL_BUG”

Please check the issue description below to find the “URL_BUG” that will allow you to reproduce the issue reported.

• Assignee: Unassigned
• Reporter: Johannes Kloos
• Created: 31/Jan/19 14:22
• Updated: 29/Dec/19 20:51
• Resolved: 04/Nov/19 18:23

Description

Requesting the following URL causes Solr to return an HTTP 500 error response:

http://localhost:8983/solr/films/select?mm=%3C&defType=edismax&q=fq=field(id,1)

The error response seems to be caused by the following uncaught exception:

java.lang.ArrayIndexOutOfBoundsException: 0
at org.apache.solr.util.SolrPluginUtils.calculateMinShouldMatch(SolrPluginUtils.java:683)
at org.apache.solr.util.SolrPluginUtils.setMinShouldMatch(SolrPluginUtils.java:641)
at org.apache.solr.util.SolrPluginUtils.setMinShouldMatch(SolrPluginUtils.java:660)
at org.apache.solr.search.ExtendedDismaxQParser.parseOriginalQuery(ExtendedDismaxQParser.java:415)
at org.apache.solr.search.ExtendedDismaxQParser.parse(ExtendedDismaxQParser.java:173)
at org.apache.solr.search.QParser.getQuery(QParser.java:173)
at org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:158)
at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:272)
at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:2559)

The mm parameter is given as ‘<’. It is (after some string mangling) split into sub-strings separated by ‘<’, putattively giving the left-hand and right-hand argument of the operator. In the example, there are no such arguments, so the resulting array “parts” is empty (cf. String.split documentation). But we immediately try to access parts[0], leading to an AIOOBE.

To set up an environment to reproduce this bug, follow the description in the ‘Environment’ field.

We automatically found this issue and ~70 more like this using Diffblue Microservices Testing. Find more information on this fuzz testing campaign.

Issue Links

• links to: GitHub Pull Request #978