[SOLR-12880] Show the FacetProcessor class name instead of the FacetRequest in the JSON Facets debug-trace output

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 7.5
• Fix Version/s: 7.6
• Component/s: Facet Module
• Assignee: David Smiley
• Reporter: Tim Underwood
• Created: 17/Oct/18 20:00
• Updated: 08/Jun/19 15:01
• Resolved: 09/Nov/18 04:40

Description

In the "facet-trace" debug output for the JSON facets the "processor" field current shows the class name of the FacetRequest implementation (e.g. FacetField, FacetQuery, FacetRange, etc.). It seems like this would be more useful if it showed the FacetProcessor class being used instead (e.g. FacetFieldProcessorByArrayDV, FacetFieldProcessorByHashDV, FacetQueryProcessor, FacetRangeProcessor, etc.)

Example of how it works today:

"debug": {
  "facet-trace": {
    "processor": FacetQuery "elapse": 50 "query": null "domainSize": 3296 "sub-facet": [{
      processor = FacetField,
      elapse = 18,
      field = partTypeId,
      limit = -1,
      domainSize = 3296,
      numBuckets = 392
    }, {
      processor = FacetField,
      elapse = 25,
      field = browseNodeId,
      limit = -1,
      domainSize = 3296,
      numBuckets = 535
    }]
  }
}

This is what showing the FacetProcessor class name would show:

"debug": {
  "facet-trace": {
    "processor": FacetQueryProcessor "elapse": 77 "query": null "domainSize": 3442 "sub-facet": [{
      processor = FacetFieldProcessorByHashDV,
      elapse = 3,
      field = partTypeId,
      limit = -1,
      domainSize = 3442,
      numBuckets = 407
    }, {
      processor = FacetFieldProcessorByHashDV,
      elapse = 4,
      field = browseNodeId,
      limit = -1,
      domainSize = 3442,
      numBuckets = 553
    }]
  }
}

Alternatively an additional debug field could be added with this information.

Issue Links

• links to: GitHub Pull Request #474
• links to: GitHub Pull Request #474