[SOLR-12516] JSON "range" facets can incorrectly refine subfacets for buckets

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.5, 8.0
• Component/s: Facet Module
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 25/Jun/18 17:43
• Updated: 08/Jun/19 15:03
• Resolved: 06/Jul/18 17:52

Description

while simple type:range facets don't benefit from refinement, because every shard returns the same set of buckets, some bugs currently exist when a range facet contains sub facets that use refinement:

1. the optional other buckets (before/after/between) are not considered during refinement
2. when using the include option: if edge is specified, then the refinement of all range buckets mistakenly includes the lower bound of the range, regardless of whether lower was specified.

---

#1 occurs because FacetRangeMerger extends FacetRequestSortedMerger<FacetRange> ... however FacetRangeMerger does not override getRefinement(...) which means only FacetRequestSortedMerger.buckets is evaluated and considered for refinement. The additional, special purpose, FacetBucket instances tracked in FacetRangeMerger are never considered for refinement.

#2 exists because of a mistaken in the implementation of refineBucket and how it computes the start value.

Issue Links

• relates to: SOLR-12343 JSON Field Facet refinement can return incorrect counts/stats for sorted buckets