Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.5
    • None
    • None

    Description

      Once SolrInputDocument supports labeled child documents, XmlLoader should add the child document to the map while saving its key name, to maintain the child's relationship to its parent.

      Attachments

        Issue Links

        Activity

          moshebla mosh added a comment -

          Hey,
          just opened a pull request with a basic test which adds labelled children in an xml document.

          moshebla mosh added a comment - Hey, just opened a pull request with a basic test which adds labelled children in an xml document.

          Commit 38bf976cd4b9e324c21664bd7ae3d554df803705 in lucene-solr's branch refs/heads/master from Moshe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=38bf976 ]

          SOLR-12485: Solr-Update XML format now accepts child documents under a field
          thus providing a semantic relationship. (like allowed for JSON).
          Improved XML.java a bit
          Closes #430

          jira-bot ASF subversion and git services added a comment - Commit 38bf976cd4b9e324c21664bd7ae3d554df803705 in lucene-solr's branch refs/heads/master from Moshe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=38bf976 ] SOLR-12485 : Solr-Update XML format now accepts child documents under a field thus providing a semantic relationship. (like allowed for JSON). Improved XML.java a bit Closes #430

          Commit b7f14648fadc9b4d2856759bcdb93768f73ff8bc in lucene-solr's branch refs/heads/branch_7x from Moshe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b7f1464 ]

          SOLR-12485: Solr-Update XML format now accepts child documents under a field
          thus providing a semantic relationship. (like allowed for JSON).
          Improved XML.java a bit
          Closes #430

          (cherry picked from commit 38bf976)

          jira-bot ASF subversion and git services added a comment - Commit b7f14648fadc9b4d2856759bcdb93768f73ff8bc in lucene-solr's branch refs/heads/branch_7x from Moshe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b7f1464 ] SOLR-12485 : Solr-Update XML format now accepts child documents under a field thus providing a semantic relationship. (like allowed for JSON). Improved XML.java a bit Closes #430 (cherry picked from commit 38bf976)
          dsmiley David Smiley added a comment -

          Thanks Moshe.

          BTW while crafting the CHANGES.txt message to be similar to the JSON variant of this issue, I realized we aren't honoring the anonChildDocs param. I think it doesn't matter here since the XML format is very explicit about this, whereas the JSON syntax had more ambiguity in its structural interpretation. Any way, if we make anonChildDocs go away, fixed at "false" in master (8.0), it'll be a non-issue. We should have an issue for that. It's not quite that trivial since if you provide the key name _childDocuments_ then it's definitely an anonymous child doc (thus should ignore anonChildDocs). One new issue can handle that. I'll create it.

          dsmiley David Smiley added a comment - Thanks Moshe. BTW while crafting the CHANGES.txt message to be similar to the JSON variant of this issue, I realized we aren't honoring the anonChildDocs param. I think it doesn't matter here since the XML format is very explicit about this, whereas the JSON syntax had more ambiguity in its structural interpretation. Any way, if we make anonChildDocs go away, fixed at "false" in master (8.0), it'll be a non-issue. We should have an issue for that. It's not quite that trivial since if you provide the key name _childDocuments_ then it's definitely an anonymous child doc (thus should ignore anonChildDocs). One new issue can handle that. I'll create it.

          People

            dsmiley David Smiley Assign to me
            moshebla mosh
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 4.5h
              4.5h

              Slack