[SOLR-1207] equals method should compare this and other of DocList in DocSetBase

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2, 1.3, 1.4
• Fix Version/s: 1.4
• Component/s: search
• Assignee: Koji Sekiguchi
• Reporter: Koji Sekiguchi
• Created: 08/Jun/09 02:18
• Updated: 10/Nov/09 15:52
• Resolved: 08/Jun/09 02:29

Description

There is a fault in equals method of DocSetBase class:

if (this instanceof DocList && other instanceof DocList) {
  // compare ordering
  DocIterator i1=this.iterator();
  DocIterator i2=this.iterator();       // <== *this should be other*
  while(i1.hasNext() && i2.hasNext()) {
    if (i1.nextDoc() != i2.nextDoc()) return false;
  }
  return true;
  // don't compare matches
}