[SOLR-11620] Occasional NullPointerException in CloudSolrClient

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.6.1
• Fix Version/s: 7.2, 8.0
• Component/s: SolrJ
• Assignee: Tomas Eduardo Fernandez Lobbe
• Reporter: Rob Trickey
• Created: 08/Nov/17 09:52
• Updated: 08/Jun/19 15:16
• Resolved: 21/Dec/17 00:50

Description

When sending document updates to Solr, we occasionally see the following error:

java.lang.NullPointerException
	at org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1182)
	at org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1073)
	at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160)
	at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:173)
	at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:138)
	at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:152)

Looking at the code, there is a lack of null check on requestedCollections around the for loop
for (DocCollection ext : requestedCollections)
which causes the error. Wrapping this loop with if(requestedCollections != null) would solve the problem.

Issue Links

• links to: GitHub Pull Request #264