[SOLR-11336] DocBasedVersionConstraintsProcessor should be more extensible and support multiple version fields

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.4
• Assignee: David Smiley
• Reporter: Michael Braun
• Created: 07/Sep/17 21:47
• Updated: 08/Jun/19 15:20
• Resolved: 12/Apr/18 18:42

Description

DocBasedVersionConstraintsProcessor supports allowing document updates only if the new version is greater than the old. However, if any behavior wants to be extended / changed in minor ways, the entire class will need to be copied and slightly modified rather than extending and changing the method in question.

It would be nice if DocBasedVersionConstraintsProcessor stood on its own as a non-private class. In addition, certain methods (such as pieces of isVersionNewEnough) should be broken out into separate methods so they can be extended such that someone can extend the processor class and override what it means for a new version to be accepted (allowing equal versions through? What if new is a lower not greater number?).