[SOLR-11140] (private) SolrMetricManager.prepareCloudPlugins has unused parameter

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.1, 8.0
• Component/s: metrics
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 25/Jul/17 09:52
• Updated: 17/Oct/17 11:03
• Resolved: 01/Aug/17 10:47

Description

SolrMetricManager.prepareCloudPlugins is a private method and its last parameter (defaultPlugin) is always passed in as null leading to an effectively dead/unreachable block of code in the method implementation.

This ticket proposes to remove the unused parameter and associated unreachable block of code.