[SOLR-1095] StopFilterFactory should not use HashSet

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.4
• Assignee: Grant Ingersoll
• Reporter: Grant Ingersoll
• Created: 30/Mar/09 16:43
• Updated: 30/Jun/17 06:37
• Resolved: 01/Apr/09 20:18

Description

Rev 680935 of StopFilterFactory introduced some changes that can cause poor performance do to the use of HashSet instead of CharArraySet in the inform() method. I noticed this while profiling http://www.lucidimagination.com/search/document/f46f0edfc439356c/solr_user_upgrade_from_1_2_to_1_3_gives_3x_slowdown whereby 20% of the time spent in indexing occurred in Collections.addAll() in the Lucene StopFilter due to the execution of the else clause in the lines:

if (stopWords instanceof CharArraySet) {
      this.stopWords = (CharArraySet)stopWords;
    } else {
      this.stopWords = new CharArraySet(stopWords.size(), ignoreCase);
      this.stopWords.addAll(stopWords);
    }

Issue Links

• is related to: SOLR-663 Allow multiple files for stopwords, protwords and synonyms