[SOLR-10466] setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.0, main (10.0), 9.3
• Component/s: SolrJ
• Assignee: Eric Pugh
• Reporter: Jason Gerlowski
• Created: 07/Apr/17 16:47
• Updated: 22/Dec/23 20:43
• Resolved: 27/Mar/23 16:27

Description

Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

• unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
• reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

This subtask endeavors to change this behavior for the setDefaultCollection setter on all SolrClient implementations.

Issue Links

• causes: SOLR-16819 (nightly) HttpPartitionTest broken regardless of seed
• relates to: SOLR-17066 Deprecate and remove core URLs in HttpSolrClient and friends
• links to: GitHub Pull Request #1256