Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10235

fix last TestJdbcDataSource / mock issue with java9

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None

    Description

      The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still left one outstanding test that was incompatible with Java9: testRetrieveFromDriverManager()

      The way this test worked with mock classes was also sketchy, but under java9 (even with Mockito) the attempt at using class names to resolve things in the standard SQL DriverManager isn't viable.

      It seems like any easy fix is to create real class (with a real/fixed classname) that acts as a wrapper around a mockito "Driver" instance just for the purposes of checking that the DriverManaer related code is working properly.

      Attachments

        1. SOLR-10235.patch
          5 kB
          Uwe Schindler
        2. SOLR-10235.patch
          4 kB
          Uwe Schindler
        3. SOLR-10235.patch
          5 kB
          Uwe Schindler
        4. SOLR-10235.patch
          5 kB
          Uwe Schindler
        5. SOLR-10235.patch
          4 kB
          Chris M. Hostetter

        Issue Links

          Activity

            People

              uschindler Uwe Schindler
              hossman Chris M. Hostetter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: