[SMXCOMP-218] servicemix-validation throws JBIException instead of FaultException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: servicemix-validation-2008.01
• Fix Version/s: servicemix-validation-2009.01
• Component/s: servicemix-validation
• Assignee: Lars Heinemann
• Reporter: Ron Gavlin
• Created: 15/Oct/08 09:16
• Updated: 14/Feb/09 22:18
• Resolved: 15/Oct/08 09:27

Description

The old lightweight validation component used to throw a org.apache.servicemix.jbi.FaultException in the following code snippet:

if (!handlingErrorMethod.equalsIgnoreCase(FAULT_FLOW))

{ // HANDLE AS JBI FAULT throw new FaultException("Failed to validate against schema: " + schema, exchange, fault); }

else

{ MessageUtil.transfer(fault, out); return true; }

In the new servicemix-validation component, a JBIException is thrown instead of a FaultException. The relevant code snippet follows:

if (!handlingErrorMethod.equalsIgnoreCase(FAULT_FLOW))

{ // HANDLE AS JBI FAULT throw new JBIException( "Failed to validate against schema: " + schema + "\n" + new SourceTransformer().toString(fault.getContent())); }

else

{ MessageUtil.transfer(fault, out); }

The new servicemix-validation component does not seem correct to me. It should throw a FaultException rather than a JBIException. I would suggest a unit test be written to verify this behavior.

Ron