[SMXCOMP-148] Refactor JmsProviderEndpoint to not use reflection to call protected method on Spring JmsTemplate class

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: servicemix-jms-2008.01
• Fix Version/s: 3.2.4, servicemix-jms-2009.01
• Component/s: servicemix-jms
• Patch Info: Patch Available
• Assignee: Guillaume Nodet
• Reporter: Torsten Mielke
• Created: 03/Feb/09 15:45
• Updated: 14/Feb/09 22:00
• Resolved: 04/Feb/09 13:58

Description

A recent fix changed JmsProviderEndpoint.java and calls the Spring JmsTemplate protected method doSend() directly via reflection.

Method method = JmsTemplate.class.getDeclaredMethod("doSend", Session.class, Destination.class, MessageCreator.class);
method.setAccessible(true);
method.invoke(template, session, dest, new MessageCreator() {
  public Message createMessage(Session session) throws JMSException {
     return message;
  }
});

This new approach is based on java.lang.reflect and uses private methods of the JmsTemplate. Do the latest problem related to JmsProviderEndpoint really justify using private methods?
Please consider refactoring the code above.