[SMX4-791] Make allowCoreThreadTimeOut name consistent across mbeans and properties

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.4.0
• Assignee: Freeman Yue Fang
• Reporter: Freeman Yue Fang
• Created: 30/Mar/11 05:16
• Updated: 30/Mar/11 07:41
• Resolved: 30/Mar/11 07:41

Description

Currently different names are used for properties and different in mbean display
org.apache.servicemix.nmr.osgi.ExecutorConfigurator has allowCoreThreadsTimeout (with 's' and small 'o') and this is the name of the property that should be used in config file for it to work (ExecutorConfig in smx-utils has allowCoreThreadsTimeout too).

Then ExecutorFactoryImpl uses it to populate allowCoreThreadTimeOut property of thread pool executor (no 's', big 'O')

if (config.isAllowCoreThreadsTimeout()) {
            try {
                Method mth = service.getClass().getMethod("allowCoreThreadTimeOut", new Class[]{boolean.class});
                mth.invoke(service, new Object[]{Boolean.TRUE});
            }

So two versions of the name of the same property. Probably all should be changed to the one used on ThreadPoolExecutor as "allowCoreThreadTimeOut"

Issue Links

• is related to: SMX4NMR-264 Make allowsCoreThreadTimeOut name consistent across mbeans and properties
• relates to: SMXCOMP-863 Make allowsCoreThreadTimeOut name consistent across mbeans and properties