[SLING-12113] CPConverter: Improve error message "File being unzipped is too big" for Sling-Initial-Content

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Content-Package to Feature Model Converter 1.3.4
• Fix Version/s: Content-Package to Feature Model Converter 1.3.6
• Component/s: Feature Model
• Assignee: Stefan Seifert
• Reporter: Stefan Seifert
• Created: 20/Oct/23 08:05
• Updated: 04/Mar/24 13:47
• Resolved: 20/Oct/23 08:23

Description

if you use an OSGi bundle with Sling-Initial-Content, and the size of the unzipped content exceeds 100MB, currently an error messages without any context (out of a complex build) is issued:

Caused by: java.lang.IllegalStateException: File being unzipped is too big.
    at org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.SlingInitialContentBundleEntryMetaDataCollector.collectFromContextAndWriteTmpFiles (SlingInitialContentBundleEntryMetaDataCollector.java:105)
    at org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.BundleSlingInitialContentExtractor.extract (BundleSlingInitialContentExtractor.java:80)
    at org.apache.sling.feature.cpconverter.handlers.SlingInitialContentBundleHandler.processBundleInputStream (SlingInitialContentBundleHandler.java:53)
    at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.handle (BundleEntryHandler.java:141)
...

this error messages should be improved to include the actual file name, and the actual limit that was hit (it's hard-coded 100MB in this case).

Issue Links

• links to: GitHub Pull Request #172