Uploaded image for project: 'Spatial Information Systems'
  1. Spatial Information Systems
  2. SIS-85

Consider removing metadata synchronization

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.3
    • Metadata
    • None

    Description

      All subclasses of ISOMetadata are currently synchronized. It probably doesn't have significant impact on the JAR file size, since (in my understanding) adding a synchronized keyword in the method signature just set a bit in a bitmask. However it may be a cause of thread contention.

      Synchronization may not be necessary since the typical usage of metadata objects is:

      • Create the metadata object once in a single thread.
      • Declare the metadata as unmodifiable.
      • Allow any thread to read (but not set) the metadata properties.

      The potential contention, especially on metadata object shared by many other objects, would be unfortunate. However profiling this not show significant bottleneck yet.

      Attachments

        Activity

          People

            desruisseaux Martin Desruisseaux
            desruisseaux Martin Desruisseaux
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: